Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to address resolution for chained internal calls #952

Merged
merged 7 commits into from
Jan 25, 2021

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Jan 23, 2021

Summary of changes
Changes introduced in this pull request:

  • Resolution of to address must exist here for chained internal calls. This was caught because a msig execution where the message sends to a non-id address, it wasn't being resolved when executing.
  • Refactored vm to handle all cases exactly and for readability (open to suggestions on naming, send, internal_send, and execute_send isn't ideal, but internal_send matching Lotus naming and the other two are needed to make interactions cleaner)

Reference issue to close (if applicable)

Closes

Other information and links

vm/interpreter/src/default_runtime.rs Outdated Show resolved Hide resolved
@austinabell austinabell merged commit ce37d70 into main Jan 25, 2021
@austinabell austinabell deleted the austin/fix/msigreso branch January 25, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants