Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case in update pending deal state #968

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • So the issue is that the epochs elapsed value can go negative (which seems like a bug) but the u64 cast caused it to overflow and fail to send which caused a state diff
    • My guess is this is an artifact from when we were using unsigned big ints and validating, and this just didn't get noticed to remove the cast as a side effect
  • Also switched the logic to more identically match Lotus for the end epoch

Fixes state diff at height 438854

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit c565eb9 into main Jan 26, 2021
@austinabell austinabell deleted the austin/fix/pds branch January 26, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants