Include git hash and crate version #977
Conversation
RajarupanSampanthan
requested review from
austinabell,
dutterbutter and
ec2
as code owners
node/forest_libp2p/src/behaviour.rs
Outdated
| // TODO update to include actual version | ||
| // https://github.com/ChainSafe/forest/issues/934 | ||
| format!("forest-{}", "0.1.0"), | ||
| format!("forest-{}", *VERSION), |
There was a problem hiding this comment.
nice! Can you add that same commit hash at the end of this as well? Something like
| format!("forest-{}", *VERSION), | |
| format!("forest-{}-{}", *VERSION, *CURRENT_COMMIT), |
Sorry if the issue was unclear. If not I can just do it in a following PR.
node/forest_libp2p/Cargo.toml
Outdated
| @@ -7,6 +7,7 @@ edition = "2018" | |||
| [dependencies] | |||
| utils = { path = "../utils" } | |||
| networks = { path = "../../types/networks" } | |||
| fil_types = { path = "../../types" } | |||
There was a problem hiding this comment.
sorry for the nit, but can you avoid bringing this dependency into the libp2p crate? Since the type is as simple as just git_version!(), maybe just have that in place of CURRENT_COMMIT
There was a problem hiding this comment.
Hey @nannick, this PR looks great and I'd like to pull it in. The branch just needs to be updated and that last change (#977 (comment)) made. If you give me privileges to modify your branch I can do this for you, if you'd like :)
Sorry for the late fix on such a small PR
node/forest_libp2p/Cargo.toml
Outdated
| @@ -7,6 +7,7 @@ edition = "2018" | |||
| [dependencies] | |||
| utils = { path = "../utils" } | |||
| networks = { path = "../../types/networks" } | |||
| fil_types = { path = "../../types" } | |||
There was a problem hiding this comment.
| fil_types = { path = "../../types" } |
|
Hey @nannick, this PR looks great and I'd like to pull it in. The branch just needs to be updated and that last change (#977 (comment)) made. If you give me privileges to modify your branch I can do this for you, if you'd like :) |
|
Thank you so much for this! This will be nice to have |
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
#934
Other information and links