Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Car file read node #988

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Improve Car file read node #988

merged 2 commits into from
Feb 8, 2021

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Noticed when looking around, there is no need to convert the cid to bytes just to get the amount of bytes read.

Reference issue to close (if applicable)

Closes

Other information and links

cryptoquick
cryptoquick approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

ec2
ec2 approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@austinabell austinabell merged commit 8390604 into main Feb 8, 2021
@austinabell austinabell deleted the austin/carchange branch February 8, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoquick cryptoquick cryptoquick approved these changes

@ec2 ec2 ec2 approved these changes

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
Enhancement Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@austinabell @cryptoquick @ec2