Remove ref keyword usage #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ec2,
ansermino,
GregTheGreek and
dutterbutter
|
Do you have a reference to how you came to that conclusion? |
I mean, other than it making logical sense from not dereferencing and referencing specific elements in the match, noticed it had been changed in serde specifically here: serde-rs/serde@b24d501 by David Tolnay, who is one of the main Rust contributors from what I've seen. |
ec2
approved these changes
Dec 12, 2019
dutterbutter
approved these changes
Dec 12, 2019
ansermino
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just discovered ref usage like this in matching should be avoided (primarily for stylistic reasons) but I figured I would fix the current usages so this didn't become the standard. Let me know if you guys agree