New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and re-enable handleChainReorg by filtering inherents #1426

Closed

noot opened this issue Mar 1, 2021 · 0 comments · Fixed by #1609

Assignees

Contributor

noot commented Mar 1, 2021

Task summary

core.Service.handleChainReorg needs to be fixed (currently disabled)
on a chain re-org it attempts to re-add every extrinsic from every block on the re-orged chain, however it does not filter inherents, causing a lot of failed to call validate_transaction errors
need to filter extrinsics, ie make sure the ones we are re-executing are signed extrinsics

The text was updated successfully, but these errors were encountered:

noot added core labels

dutterbutter removed the Status: Needs Triage label

dutterbutter added the approved label

arijitAD self-assigned this

arijitAD mentioned this issue

fix(dot/core): Add only extrinsic during chain reorg. #1609

Merged

noot closed this as completed in #1609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment