Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "no-regossip" functionality for specific messages #1532

Closed
noot opened this issue Apr 19, 2021 · 0 comments · Fixed by #1555
Closed

add "no-regossip" functionality for specific messages #1532

noot opened this issue Apr 19, 2021 · 0 comments · Fixed by #1555
Assignees

Comments

@noot
Copy link
Contributor

noot commented Apr 19, 2021

Task summary

  • certain message types shouldn't be re-gossiped such as grandpa NeighbourMessage, however currently all notifications messages are re-gossiped
  • update the notifications NotificationsMessageHandler to return a regossip bool, if this is false, don't re-gossip the message
  • update current NotificationsMessageHandlers to return regossip = true except for NeighbourMessage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants