feat: remove unnecessary direct dependency #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `iso-random-stream` direct dependency, use `randomBytes` API from `@libp2p/crypto` instead. `iso-random-stream` brings in `buffer` dependency which then needs to be polyfilled when targeting the browser.
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 81.44% 81.44%
=======================================
Files 43 43
Lines 9451 9451
Branches 917 917
=======================================
Hits 7697 7697
Misses 1754 1754
Continue to review full report at Codecov.
|
wemeetagain
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
iso-random-streamdirect dependency, userandomBytesAPI from@libp2p/cryptoinstead.iso-random-streambrings inbufferdependency which then needs to bepolyfilled when targeting the browser.
Related: libp2p/js-libp2p-crypto#262