feat!: close streams gracefully #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates all libp2p related deps - Switches `it-pb-stream` for `it-length-prefixed-stream` since we only use the methods from that module - Stream close methods are now async BREAKING CHANGE: stream close methods are now asyc, requires libp2p@0.46.x or later
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
=======================================
Coverage 82.30% 82.30%
=======================================
Files 48 48
Lines 12035 12039 +4
Branches 1281 1286 +5
=======================================
+ Hits 9905 9909 +4
Misses 2130 2130
☔ View full report in Codecov by Sentry. |
wemeetagain
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it-pb-streamforit-length-prefixed-streamsince we only use the methods from that moduleBREAKING CHANGE: stream close methods are now asyc, requires libp2p@0.46.x or later