fix: send data during graceful close. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a stream is closed gracefully, it's status goes from `'open'` to `'closing'` then to either `'closed'`, `'aborted'` or `'reset'`. While it's `'closing'` we should still try to send any queued data, this can be aborted by calling `.abort` on the stream or by the signal passed to `.close` firing the `'abort'` event. This change makes the tests added in libp2p/js-libp2p#2398 pass.
wemeetagain
approved these changes
Feb 7, 2024
achingbrain
added a commit
that referenced
this pull request
Feb 8, 2024
#73 was merged on red, this fixes the build
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a stream is closed gracefully, it's status goes from
'open'to'closing'then to either'closed','aborted'or'reset'.While it's
'closing'we should still try to send any queued data, this can be aborted by calling.aborton the stream or by the signal passed to.closefiring the'abort'event.This change makes the tests added in libp2p/js-libp2p#2398 pass, in particular the one where we use
it-byte-streamand write data larger than the send capacity. When this happens we wait for the remote to signal to accept more data, during which time the stream is closed gracefully and the data ends up being truncated as we stop sending whenthis.statusis no longer'open'.