Update metrics

ChainSafe · Apr 16, 2024 · 1fab30d · 1fab30d
1 parent 52d207e
commit 1fab30d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/packages/beacon-node/src/chain/chain.ts b/packages/beacon-node/src/chain/chain.ts
@@ -736,9 +736,9 @@ export class BeaconChain implements IBeaconChain {
         secFromSlot,
         slot,
       });
-      this.metrics?.forkChoice.isBlockTimely.set(isHeadTimely ? 1 : 0);
-      if (notReorgedReason !== undefined) {
-        this.metrics?.forkChoice.notReorgedReason.set(notReorgedReason);
+
+      if (isHeadTimely && notReorgedReason !== undefined) {
+        this.metrics?.forkChoice.notReorgedReason.inc({reason: notReorgedReason});
       }
       return head;
     } catch (e) {

diff --git a/packages/beacon-node/src/metrics/metrics/beacon.ts b/packages/beacon-node/src/metrics/metrics/beacon.ts
@@ -1,4 +1,5 @@
 import {ProducedBlockSource} from "@lodestar/types";
+import {NotReorgedReason} from "@lodestar/fork-choice/lib/forkChoice/interface.js";
 import {RegistryMetricCreator} from "../utils/registryMetricCreator.js";
 import {BlockProductionStep, PayloadPreparationType} from "../../chain/produceBlock/index.js";
 
@@ -110,13 +111,10 @@ export function createBeaconMetrics(register: RegistryMetricCreator) {
         name: "beacon_fork_choice_indices_count",
         help: "Current count of indices in fork choice data structures",
       }),
-      isBlockTimely: register.gauge({
-        name: "beacon_fork_choice_is_block_timely",
-        help: "Whether the current head (or original head if re-orged out because it is late) is timely or not",
-      }),
-      notReorgedReason: register.gauge({
+      notReorgedReason: register.gauge<{reason: NotReorgedReason}>({
         name: "beacon_fork_choice_not_reorged_reason",
         help: "Reason why the current head is not re-orged out",
+        labelNames: ["reason"],
       }),
     },