Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SyncCommittee signature set in all block sigs #2610

Closed
dapplion opened this issue Jun 1, 2021 · 0 comments · Fixed by #2617
Closed

Add SyncCommittee signature set in all block sigs #2610

dapplion opened this issue Jun 1, 2021 · 0 comments · Fixed by #2617
Labels
prio-high Resolve issues as soon as possible.

Comments

@dapplion
Copy link
Contributor

dapplion commented Jun 1, 2021

Describe the bug

We do not include the SyncCommittee signature in this all blocks sig bundle

export function getAllBlockSignatureSetsExceptProposer(
state: CachedBeaconState<allForks.BeaconState>,
signedBlock: allForks.SignedBeaconBlock
): ISignatureSet[] {
return [
getRandaoRevealSignatureSet(state, signedBlock.message),
...getProposerSlashingsSignatureSets(state, signedBlock),
...getAttesterSlashingsSignatureSets(state, signedBlock),
...getAttestationsSignatureSets(state, signedBlock),
...getVoluntaryExitsSignatureSets(state, signedBlock),
];

Expected behavior

We must verify all signatures in a block

@dapplion dapplion added the prio-high Resolve issues as soon as possible. label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Resolve issues as soon as possible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant