Validate SyncCommitteeSignatureSet #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit c40e91a and detected 0 issues on this pull request. View more on Code Climate. |
dapplion
force-pushed
the
dapplion/synccommitte-sigset
branch
from
89dd4e3
to
0cdcb53
Compare
dapplion
force-pushed
the
dapplion/synccommitte-sigset
branch
from
0cdcb53
to
c3432ec
Compare
twoeths
approved these changes
Jun 3, 2021
twoeths
reviewed
Jun 3, 2021
| ): ISignatureSet | null { | ||
| const {config, epochCtx} = state; | ||
|
|
||
| const previousSlot = Math.max(state.slot, 1) - 1; |
There was a problem hiding this comment.
@dapplion previousSlot should be from Math.max(block.slot, 1) - 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #2610
Description
Closes #2610