Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error adding gossip attestations to forkchoice #3665

Closed
twoeths opened this issue Jan 25, 2022 · 1 comment · Fixed by #3671
Closed

Error adding gossip attestations to forkchoice #3665

twoeths opened this issue Jan 25, 2022 · 1 comment · Fixed by #3671
Assignees

Comments

@twoeths
Copy link
Contributor

twoeths commented Jan 25, 2022

Describe the bug

Found this in the log of prater node:

Jan-25 11:28:50.045 [NETWORK]         error: Error adding aggregated attestation to forkchoice slot=2216511 code=FORKCHOICE_ERROR_INVALID_ATTESTATION, err={"code":"PAST_EPOCH","attestationEpoch":69265,"currentEpoch":69267}
Error: FORKCHOICE_ERROR_INVALID_ATTESTATION
    at ForkChoice.validateAttestationData (/root/lodestar/packages/fork-choice/src/forkChoice/forkChoice.ts:786:13)
    at ForkChoice.validateOnAttestation (/root/lodestar/packages/fork-choice/src/forkChoice/forkChoice.ts:763:10)
    at ForkChoice.onAttestation (/root/lodestar/packages/fork-choice/src/forkChoice/forkChoice.ts:421:10)
    at beacon_aggregate_and_proof (/root/lodestar/packages/lodestar/src/network/gossip/handlers/index.ts:179:28)
    at Object.gossipValidatorFn [as beacon_aggregate_and_proof] (/root/lodestar/packages/lodestar/src/network/gossip/validation/index.ts:110:7)
    at Eth2Gossipsub.validate (/root/lodestar/packages/lodestar/src/network/gossip/gossipsub.ts:282:7)
    at Eth2Gossipsub._processRpcMessage (/root/lodestar/node_modules/libp2p-interfaces/src/pubsub/index.js:449:7)
Jan-25 11:28:50.707 [NETWORK]         error: Error adding aggregated attestation to forkchoice slot=2216511 code=FORKCHOICE_ERROR_INVALID_ATTESTATION, err={"code":"PAST_EPOCH","attestationEpoch":69265,"currentEpoch":69267}
Error: FORKCHOICE_ERROR_INVALID_ATTESTATION
    at ForkChoice.validateAttestationData (/root/lodestar/packages/fork-choice/src/forkChoice/forkChoice.ts:786:13)

Expected behavior

No error

@twoeths twoeths self-assigned this Jan 25, 2022
@twoeths
Copy link
Contributor Author

twoeths commented Jan 27, 2022

this happens at the last slot of epoch. At the time we validate aggregated attestation, the slot is acceptable. Right after that, the clock is ticked to next epoch so the aggregated attestation becomes invalid when passing to forkchoice.

The only issue I see is logging level: the log is at error level while it's not really an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant