Use debug level when passing gossip attestations to forkchoice error

[twoeths]

Motivation

When passing gossip attestations to forkchoice and there are error, it does not affect the functionality while it's logged as logger.error, switch to using logger.debug() so that we can investigate further if needed

Description

Closes #3665

[codeclimate]

Code Climate has analyzed commit 98be032 and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

Merging #3671 (98be032) into master (a00ec5c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3671   +/-   ##
=======================================
  Coverage   37.13%   37.13%           
=======================================
  Files         321      321           
  Lines        8706     8706           
  Branches     1350     1350           
=======================================
  Hits         3233     3233           
  Misses       5330     5330           
  Partials      143      143           

[github-actions]

Performance Report

✔️ no performance regression detected

Full benchmark results

Benchmark suite	Current: 22b1023	Previous: a00ec5c	Ratio
BeaconState.hashTreeRoot - No change	515.00 ns/op	732.00 ns/op	0.70
BeaconState.hashTreeRoot - 1 full validator	131.78 us/op	175.59 us/op	0.75
BeaconState.hashTreeRoot - 32 full validator	1.8661 ms/op	2.6951 ms/op	0.69
BeaconState.hashTreeRoot - 512 full validator	25.549 ms/op	35.774 ms/op	0.71
BeaconState.hashTreeRoot - 1 validator.effectiveBalance	130.07 us/op	186.50 us/op	0.70
BeaconState.hashTreeRoot - 32 validator.effectiveBalance	2.0657 ms/op	2.8927 ms/op	0.71
BeaconState.hashTreeRoot - 512 validator.effectiveBalance	27.845 ms/op	38.581 ms/op	0.72
BeaconState.hashTreeRoot - 1 balances	91.698 us/op	129.87 us/op	0.71
BeaconState.hashTreeRoot - 32 balances	816.51 us/op	1.0822 ms/op	0.75
BeaconState.hashTreeRoot - 512 balances	7.2736 ms/op	10.310 ms/op	0.71
BeaconState.hashTreeRoot - 250000 balances	151.81 ms/op	185.13 ms/op	0.82
processSlot - 1 slots	54.911 us/op	84.875 us/op	0.65
processSlot - 32 slots	3.1144 ms/op	4.1331 ms/op	0.75
getCommitteeAssignments - req 1 vs - 250000 vc	4.3538 ms/op	6.0059 ms/op	0.72
getCommitteeAssignments - req 100 vs - 250000 vc	6.0239 ms/op	8.3912 ms/op	0.72
getCommitteeAssignments - req 1000 vs - 250000 vc	6.5104 ms/op	9.1545 ms/op	0.71
computeProposers - vc 250000	21.459 ms/op	28.206 ms/op	0.76
computeEpochShuffling - vc 250000	163.89 ms/op	221.08 ms/op	0.74
getNextSyncCommittee - vc 250000	337.72 ms/op	465.10 ms/op	0.73
altair processAttestation - 250000 vs - 7PWei normalcase	107.24 ms/op	57.013 ms/op	1.88
altair processAttestation - 250000 vs - 7PWei worstcase	42.975 ms/op	55.940 ms/op	0.77
altair processAttestation - setStatus - 1/6 committees join	10.178 ms/op	16.894 ms/op	0.60
altair processAttestation - setStatus - 1/3 committees join	20.394 ms/op	34.945 ms/op	0.58
altair processAttestation - setStatus - 1/2 committees join	35.488 ms/op	51.867 ms/op	0.68
altair processAttestation - setStatus - 2/3 committees join	42.554 ms/op	70.189 ms/op	0.61
altair processAttestation - setStatus - 4/5 committees join	55.427 ms/op	82.215 ms/op	0.67
altair processAttestation - setStatus - 100% committees join	73.744 ms/op	105.40 ms/op	0.70
altair processAttestation - updateEpochParticipants - 1/6 committees join	12.664 ms/op	18.489 ms/op	0.68
altair processAttestation - updateEpochParticipants - 1/3 committees join	25.393 ms/op	33.340 ms/op	0.76
altair processAttestation - updateEpochParticipants - 1/2 committees join	30.397 ms/op	31.334 ms/op	0.97
altair processAttestation - updateEpochParticipants - 2/3 committees join	26.342 ms/op	42.223 ms/op	0.62
altair processAttestation - updateEpochParticipants - 4/5 committees join	29.696 ms/op	35.245 ms/op	0.84
altair processAttestation - updateEpochParticipants - 100% committees join	28.724 ms/op	37.623 ms/op	0.76
altair processAttestation - updateAllStatus	20.847 ms/op	27.025 ms/op	0.77
altair processBlock - 250000 vs - 7PWei normalcase	44.552 ms/op	56.301 ms/op	0.79
altair processBlock - 250000 vs - 7PWei worstcase	137.64 ms/op	158.68 ms/op	0.87
altair processEpoch - mainnet_e81889	1.0894 s/op	1.4360 s/op	0.76
mainnet_e81889 - altair beforeProcessEpoch	370.73 ms/op	345.31 ms/op	1.07
mainnet_e81889 - altair processJustificationAndFinalization	113.51 us/op	114.91 us/op	0.99
mainnet_e81889 - altair processInactivityUpdates	17.920 ms/op	21.476 ms/op	0.83
mainnet_e81889 - altair processRewardsAndPenalties	254.07 ms/op	308.37 ms/op	0.82
mainnet_e81889 - altair processRegistryUpdates	19.835 us/op	19.817 us/op	1.00
mainnet_e81889 - altair processSlashings	5.9920 us/op	5.6160 us/op	1.07
mainnet_e81889 - altair processEth1DataReset	5.7860 us/op	6.2030 us/op	0.93
mainnet_e81889 - altair processEffectiveBalanceUpdates	12.650 ms/op	16.350 ms/op	0.77
mainnet_e81889 - altair processSlashingsReset	33.600 us/op	32.809 us/op	1.02
mainnet_e81889 - altair processRandaoMixesReset	37.813 us/op	41.014 us/op	0.92
mainnet_e81889 - altair processHistoricalRootsUpdate	7.7740 us/op	8.5450 us/op	0.91
mainnet_e81889 - altair processParticipationFlagUpdates	166.28 ms/op	198.50 ms/op	0.84
mainnet_e81889 - altair processSyncCommitteeUpdates	5.0000 us/op	5.3110 us/op	0.94
mainnet_e81889 - altair afterProcessEpoch	230.63 ms/op	266.11 ms/op	0.87
altair processInactivityUpdates - 250000 normalcase	83.192 ms/op	90.734 ms/op	0.92
altair processInactivityUpdates - 250000 worstcase	75.255 ms/op	90.202 ms/op	0.83
altair processParticipationFlagUpdates - 250000 anycase	98.895 ms/op	110.30 ms/op	0.90
altair processRewardsAndPenalties - 250000 normalcase	223.23 ms/op	280.60 ms/op	0.80
altair processRewardsAndPenalties - 250000 worstcase	253.31 ms/op	313.43 ms/op	0.81
altair processSyncCommitteeUpdates - 250000	386.92 ms/op	499.77 ms/op	0.77
Tree 40 250000 create	1.0244 s/op	1.1713 s/op	0.87
Tree 40 250000 get(125000)	390.16 ns/op	827.85 ns/op	0.47
Tree 40 250000 set(125000)	2.2500 us/op	2.9390 us/op	0.77
Tree 40 250000 toArray()	55.109 ms/op	61.370 ms/op	0.90
Tree 40 250000 iterate all - toArray() + loop	44.108 ms/op	49.015 ms/op	0.90
Tree 40 250000 iterate all - get(i)	117.56 ms/op	146.47 ms/op	0.80
MutableVector 250000 create	27.718 ms/op	25.473 ms/op	1.09
MutableVector 250000 get(125000)	13.151 ns/op	16.783 ns/op	0.78
MutableVector 250000 set(125000)	658.45 ns/op	790.27 ns/op	0.83
MutableVector 250000 toArray()	9.6221 ms/op	10.724 ms/op	0.90
MutableVector 250000 iterate all - toArray() + loop	9.4845 ms/op	10.782 ms/op	0.88
MutableVector 250000 iterate all - get(i)	3.3827 ms/op	3.9828 ms/op	0.85
Array 250000 create	5.3824 ms/op	6.3392 ms/op	0.85
Array 250000 clone - spread	2.3091 ms/op	2.2408 ms/op	1.03
Array 250000 get(125000)	1.0790 ns/op	1.1330 ns/op	0.95
Array 250000 set(125000)	1.0860 ns/op	1.0890 ns/op	1.00
Array 250000 iterate all - loop	133.24 us/op	157.97 us/op	0.84
aggregationBits - 2048 els - readonlyValues	243.13 us/op	278.34 us/op	0.87
aggregationBits - 2048 els - zipIndexesInBitList	47.441 us/op	48.008 us/op	0.99
regular array get 100000 times	51.854 us/op	63.295 us/op	0.82
wrappedArray get 100000 times	50.237 us/op	63.164 us/op	0.80
arrayWithProxy get 100000 times	29.477 ms/op	39.639 ms/op	0.74
ssz.Root.equals	1.2670 us/op	6.0190 us/op	0.21
ssz.Root.equals with valueOf()	1.5270 us/op	1.7650 us/op	0.87
byteArrayEquals with valueOf()	1.4860 us/op	1.6520 us/op	0.90
phase0 processBlock - 250000 vs - 7PWei normalcase	12.816 ms/op	14.069 ms/op	0.91
phase0 processBlock - 250000 vs - 7PWei worstcase	92.619 ms/op	104.11 ms/op	0.89
phase0 afterProcessEpoch - 250000 vs - 7PWei	213.65 ms/op	249.39 ms/op	0.86
phase0 beforeProcessEpoch - 250000 vs - 7PWei	736.79 ms/op	757.62 ms/op	0.97
phase0 processEpoch - mainnet_e58758	953.00 ms/op	1.1834 s/op	0.81
mainnet_e58758 - phase0 beforeProcessEpoch	541.82 ms/op	609.08 ms/op	0.89
mainnet_e58758 - phase0 processJustificationAndFinalization	116.84 us/op	118.03 us/op	0.99
mainnet_e58758 - phase0 processRewardsAndPenalties	192.52 ms/op	172.54 ms/op	1.12
mainnet_e58758 - phase0 processRegistryUpdates	86.146 us/op	83.755 us/op	1.03
mainnet_e58758 - phase0 processSlashings	7.7660 us/op	6.7840 us/op	1.14
mainnet_e58758 - phase0 processEth1DataReset	5.5850 us/op	6.6390 us/op	0.84
mainnet_e58758 - phase0 processEffectiveBalanceUpdates	10.034 ms/op	12.594 ms/op	0.80
mainnet_e58758 - phase0 processSlashingsReset	30.876 us/op	30.023 us/op	1.03
mainnet_e58758 - phase0 processRandaoMixesReset	38.713 us/op	40.361 us/op	0.96
mainnet_e58758 - phase0 processHistoricalRootsUpdate	6.9520 us/op	7.5000 us/op	0.93
mainnet_e58758 - phase0 processParticipationRecordUpdates	27.710 us/op	29.706 us/op	0.93
mainnet_e58758 - phase0 afterProcessEpoch	227.28 ms/op	223.23 ms/op	1.02
phase0 processEffectiveBalanceUpdates - 250000 normalcase	12.617 ms/op	13.816 ms/op	0.91
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5	1.7649 s/op	1.9967 s/op	0.88
phase0 processRegistryUpdates - 250000 normalcase	86.185 us/op	89.785 us/op	0.96
phase0 processRegistryUpdates - 250000 badcase_full_deposits	3.9524 ms/op	4.3844 ms/op	0.90
phase0 processRegistryUpdates - 250000 worstcase 0.5	2.7677 s/op	2.8865 s/op	0.96
phase0 getAttestationDeltas - 250000 normalcase	106.00 ms/op	102.85 ms/op	1.03
phase0 getAttestationDeltas - 250000 worstcase	99.514 ms/op	104.30 ms/op	0.95
phase0 processSlashings - 250000 worstcase	46.242 ms/op	53.812 ms/op	0.86
shuffle list - 16384 els	14.607 ms/op	16.152 ms/op	0.90
shuffle list - 250000 els	207.04 ms/op	223.17 ms/op	0.93
getEffectiveBalances - 250000 vs - 7PWei	14.868 ms/op	13.846 ms/op	1.07
pass gossip attestations to forkchoice per slot	28.736 ms/op	21.235 ms/op	1.35
computeDeltas	4.1765 ms/op	4.3307 ms/op	0.96
computeProposerBoostScoreFromBalances	300.98 us/op	315.27 us/op	0.95
getPubkeys - index2pubkey - req 1000 vs - 250000 vc	2.6199 ms/op	2.8214 ms/op	0.93
getPubkeys - validatorsArr - req 1000 vs - 250000 vc	833.59 us/op	844.87 us/op	0.99
BLS verify - blst-native	2.3245 ms/op	2.4237 ms/op	0.96
BLS verifyMultipleSignatures 3 - blst-native	4.7675 ms/op	4.9603 ms/op	0.96
BLS verifyMultipleSignatures 8 - blst-native	10.378 ms/op	10.992 ms/op	0.94
BLS verifyMultipleSignatures 32 - blst-native	37.454 ms/op	39.452 ms/op	0.95
BLS aggregatePubkeys 32 - blst-native	49.637 us/op	52.660 us/op	0.94
BLS aggregatePubkeys 128 - blst-native	192.54 us/op	200.16 us/op	0.96
getAttestationsForBlock	117.61 ms/op	113.43 ms/op	1.04
CheckpointStateCache - add get delete	23.806 us/op	27.083 us/op	0.88
validate gossip signedAggregateAndProof - struct	5.7057 ms/op	5.9995 ms/op	0.95
validate gossip signedAggregateAndProof - treeBacked	5.5648 ms/op	5.7737 ms/op	0.96
validate gossip attestation - struct	2.6178 ms/op	2.7526 ms/op	0.95
validate gossip attestation - treeBacked	2.6299 ms/op	2.7343 ms/op	0.96
bytes32 toHexString	2.1180 us/op	2.3370 us/op	0.91
bytes32 Buffer.toString(hex)	840.00 ns/op	971.00 ns/op	0.87
bytes32 Buffer.toString(hex) from Uint8Array	1.0950 us/op	1.1440 us/op	0.96
bytes32 Buffer.toString(hex) + 0x	860.00 ns/op	1.0010 us/op	0.86
Object access 1 prop	0.41100 ns/op	0.44500 ns/op	0.92
Map access 1 prop	0.34000 ns/op	0.37500 ns/op	0.91
Object get x1000	17.693 ns/op	18.781 ns/op	0.94
Map get x1000	1.0070 ns/op	1.0350 ns/op	0.97
Object set x1000	122.87 ns/op	127.32 ns/op	0.97
Map set x1000	80.663 ns/op	84.780 ns/op	0.95
Return object 10000 times	0.44620 ns/op	0.45200 ns/op	0.99
Throw Error 10000 times	7.1242 us/op	7.3643 us/op	0.97
enrSubnets - fastDeserialize 64 bits	1.6780 us/op	1.6380 us/op	1.02
enrSubnets - ssz BitVector 64 bits	19.529 us/op	20.652 us/op	0.95
enrSubnets - fastDeserialize 4 bits	554.00 ns/op	579.00 ns/op	0.96
enrSubnets - ssz BitVector 4 bits	3.4790 us/op	4.1030 us/op	0.85
RateTracker 1000000 limit, 1 obj count per request	202.28 ns/op	219.55 ns/op	0.92
RateTracker 1000000 limit, 2 obj count per request	153.56 ns/op	160.92 ns/op	0.95
RateTracker 1000000 limit, 4 obj count per request	127.47 ns/op	136.53 ns/op	0.93
RateTracker 1000000 limit, 8 obj count per request	115.33 ns/op	122.79 ns/op	0.94
RateTracker with prune	5.3310 us/op	5.6850 us/op	0.94

by benchmarkbot/action