Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block_gossip SSE event #6470

Open
nflaig opened this issue Feb 22, 2024 · 3 comments
Open

Add block_gossip SSE event #6470

nflaig opened this issue Feb 22, 2024 · 3 comments
Assignees
Labels
good first issue Issues that are suitable for first-time contributors. help-wanted The author indicates that additional help is wanted. meta-feature-request Issues to track feature requests.

Comments

@nflaig
Copy link
Member

nflaig commented Feb 22, 2024

ethereum/beacon-APIs#405

@nflaig nflaig added good first issue Issues that are suitable for first-time contributors. help-wanted The author indicates that additional help is wanted. meta-feature-request Issues to track feature requests. labels Feb 22, 2024
@Ayoseun
Copy link

Ayoseun commented Mar 4, 2024

Is this issue still open, can you assign it to me.

@matthewkeil
Copy link
Member

matthewkeil commented May 29, 2024

Thanks for reaching out on Discord @Ayoseun!!!

The block passes validation in validateGossipBlock and is handled in handleValidBeaconBlock. Please read through the discussions about the SSE event (not an inclusive list) and make sure you understand the edge cases if there are any for this event.

After briefly reading about the event, it feels like the entrance to the feature will be in handleValidBeaconBlock but will leave the implementation details up to your discretion.

Thanks for the help and feel free to message us on discord if you have any other questions.

@Ayoseun
Copy link

Ayoseun commented May 31, 2024

Thanks for this, i have gone through the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. help-wanted The author indicates that additional help is wanted. meta-feature-request Issues to track feature requests.
Projects
None yet
Development

No branches or pull requests

3 participants