Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary try / catch expect.fail() pattern #1835

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Remove unnecessary try / catch expect.fail() pattern #1835

merged 2 commits into from
Dec 7, 2020

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Dec 6, 2020

The pattern

    try {
      await jobs;
    } catch (e) {
      expect.fail();
    }

provides no extra functionality than just

      await jobs;

expect that it's muting the error so it's less useful to debug

wemeetagain
wemeetagain previously approved these changes Dec 7, 2020
View reviewed changes
@wemeetagain
Copy link
Member

file conflict

@wemeetagain wemeetagain merged commit e3ca01a into master Dec 7, 2020
@wemeetagain wemeetagain deleted the dapplion/expect.fail branch December 7, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

@twoeths twoeths Awaiting requested review from twoeths

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dapplion @wemeetagain