Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getRandaoRevealSignatureSet #1869

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Fix getRandaoRevealSignatureSet #1869

merged 1 commit into from
Dec 12, 2020

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Dec 11, 2020

resolves #1859

  • epochCtx may not be respective to the block so should not use it in getRandaoRevealSignatureSet
  • tested with Pyrmont and enabled signature verification for initial sync

@codeclimate
Copy link

codeclimate bot commented Dec 11, 2020

Code Climate has analyzed commit 4e8376d and detected 0 issues on this pull request.

View more on Code Climate.

@wemeetagain wemeetagain merged commit d2c5d44 into master Dec 12, 2020
@wemeetagain wemeetagain deleted the tuyen/fix-get-signature-set-2 branch December 12, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic mpetrunic approved these changes

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot get signature set at epoch transition
4 participants
@twoeths @wemeetagain @mpetrunic @dapplion