blockService and attestationService validator data consolidations #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3xtr4t3rr3str14l
requested review from
dapplion,
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit 8edba20 and detected 0 issues on this pull request. View more on Code Climate. |
mpetrunic
reviewed
Dec 16, 2020
|
would also like to get some feedback on this approach in particular: |
twoeths
reviewed
Jan 8, 2021
dapplion
previously requested changes
Jan 8, 2021
wemeetagain
reviewed
Jan 13, 2021
mpetrunic
reviewed
Jan 14, 2021
wemeetagain
reviewed
Jan 27, 2021
wemeetagain
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consolidating some of the validator data in
blockServiceandattestationServiceinlodestar-validatorfor example, in attestationService, we have 3 separate objects for keeping track of validator data, but we need all of those objects to be in the same order, so it seems best to consolidate them into one object.