Improve DiversifyPeersBySubnetTask #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Api
scope-networking
|
Code Climate has analyzed commit aaeda6e and detected 0 issues on this pull request. View more on Code Climate. |
twoeths
changed the title
twoeths
requested review from
dapplion,
mpetrunic and
wemeetagain
as code owners
wemeetagain
requested changes
Dec 18, 2020
| @@ -50,8 +61,8 @@ export async function handlePeerMetadataSequence( | |||
| /** | |||
| * Find subnets that we don't have at least 1 connected peer. | |||
| */ | |||
| export function findMissingSubnets(network: INetwork): number[] { | |||
| const peers = network.getPeers({connected: true}).map((peer) => peer.id); | |||
| export function findMissingSubnets(connectedPeers: LibP2p.Peer[] = [], network: INetwork): number[] { | |||
There was a problem hiding this comment.
Can we use type PeerId for connectedPeers param here and below?
Also, connectedPeers shouldn't have default value of []
There was a problem hiding this comment.
yeah I changed to PeerId[] for possible apis. Some still need to access the internal protocols so we have to go with Libp2p.Peer[].
also I removing the default [] from all of them
twoeths
force-pushed
the
tuyen/improve-DiversifyPeersBySubnetTask
branch
from
7ee14e2
to
aaeda6e
Compare
wemeetagain
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1896
Improve DiversifyPeersBySubnetTask by saving calls to
network.getPeers()network.getPeers()call