Write request decode validation as async fn #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dapplion
commented
Dec 18, 2020
dapplion
commented
- Move validation logic out of the async generator into a standalone function
- Use LodestarError pattern for validation errors
- Use RequestDecodeErrorCode in tests instead of asserting raw strings
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
github-actions
bot
added
the
scope-networking
|
Code Climate has analyzed commit 7cb87c4 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
dapplion
changed the title
dapplion
changed the title
wemeetagain
approved these changes
Dec 18, 2020
mpetrunic
reviewed
Dec 20, 2020
| if (sszDataLength === null) { | ||
| sszDataLength = decode(chunk.slice()); | ||
| if (decode.bytes > 10) { | ||
| logger.error("eth2RequestDecode: Invalid number of bytes for protobuf varint", { |
There was a problem hiding this comment.
IMO having method in log could be useful
|
|
||
| // only one request body accepted, so return | ||
| try { | ||
| return type.deserialize(buffer.slice(0, sszDataLength)); |
There was a problem hiding this comment.
I wonder if you don't break when reading from source, do you even close stream. It's been a while,
but I remember that it could hang open if you don't read everything or break. libp2p handles open and closes in post loop cleanup. I know we had some issues because if you don't finish reading that post iteration cleanup did not occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.