Fix it-pipe types #1910
Merged
Fix it-pipe types #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overwrite types until this issue is fixed alanshaw/it-pipe#4 Original types contain ``` export function pipe (first: any, ...rest: any[]): any ``` Which act as a @ts-ignore compromising type safety
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit bd1ff08 and detected 0 issues on this pull request. View more on Code Climate. |
github-actions
bot
added
the
scope-networking
mpetrunic
reviewed
Dec 22, 2020
ams-201062
previously approved these changes
Dec 22, 2020
|
As I sadi in chat. I think it would better to upstream proper types to it-pipe instead of hacking code and types like this just to make it work. IMO there is no rush to change this as this code works (without full typesafety) and we won't be required to change anything anytime soon so we can wait to get better it-pipe types upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overwrite types until this issue is fixed alanshaw/it-pipe#4
Original types contain
Which act as a @ts-ignore compromising type safety