Process chain segment #1934
Merged
Process chain segment #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
scope-networking
|
Code Climate has analyzed commit 0cdc0e9 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
twoeths
requested review from
dapplion,
mpetrunic and
wemeetagain
as code owners
dapplion
reviewed
Jan 11, 2021
dapplion
previously approved these changes
Jan 11, 2021
dapplion
reviewed
Jan 11, 2021
| @@ -105,4 +112,8 @@ export interface IBeaconChain { | |||
| * Pre-process and run the per slot state transition function | |||
| */ | |||
| receiveBlock(signedBlock: SignedBeaconBlock, trusted?: boolean): Promise<void>; | |||
There was a problem hiding this comment.
Can we change this to return void so it's not misleading? the behaviour is very different to processChainSegment
There was a problem hiding this comment.
I'd say yes, would like @wemeetagain to confirm through. I can to create a separate PR if we want to do that.
at least what I see is the name receive* vs. process* is the main difference between these 2 apis.
dapplion
previously approved these changes
Jan 13, 2021
dapplion
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1772
chain.processChainSegment()to process a linear chain until completedchain.processChainSegment(), removed its own processor