NetworkEvent object #1936
Merged
NetworkEvent object #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3xtr4t3rr3str14l
requested review from
dapplion,
mpetrunic,
twoeths and
wemeetagain
as code owners
github-actions
bot
added
the
scope-networking
|
Code Climate has analyzed commit 23adaca and detected 0 issues on this pull request. View more on Code Climate. |
twoeths
approved these changes
Jan 12, 2021
mpetrunic
reviewed
Jan 12, 2021
| peerDisconnect = "peer:disconnect", | ||
| gossipStart = "gossip:start", | ||
| gossipStop = "gossip:stop", | ||
| gossipHeartbeat = "gossipsub:heartbeat", |
There was a problem hiding this comment.
I thought we had convention to UPPER_CASE enums?
There was a problem hiding this comment.
Not sure. I just followed the convention used in ChainEvent:
dapplion
approved these changes
Jan 13, 2021
wemeetagain
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made an object to put the strings for the network events in one place.