Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata.metadata -> metadata.all #1953

Merged
merged 2 commits into from
Jan 18, 2021
Merged

metadata.metadata -> metadata.all #1953

merged 2 commits into from
Jan 18, 2021

Conversation

3xtr4t3rr3str14l
Copy link
Contributor

fixes #1741

@github-actions github-actions bot added the scope-networking All issues related to networking, gossip, and libp2p. label Jan 14, 2021
@codeclimate
Copy link

codeclimate bot commented Jan 14, 2021 •
edited

Code Climate has analyzed commit 82b2d05 and detected 0 issues on this pull request.

View more on Code Climate.

@wemeetagain wemeetagain merged commit d4e8bef into master Jan 18, 2021
@wemeetagain wemeetagain deleted the P0/metadatametadata branch January 18, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@dapplion dapplion dapplion approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

@twoeths twoeths Awaiting requested review from twoeths

Assignees
No one assigned
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename Libp2pNetwork.metadata -> metadataController or similar
3 participants
@3xtr4t3rr3str14l @wemeetagain @dapplion