Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify EpochContext #1958

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Unify EpochContext #1958

merged 1 commit into from
Jan 25, 2021

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jan 15, 2021 •
edited

From #1950 (comment)

one good thing with caching IFlatValidator (which is currently in CachedValidatorsBeaconState) is we can pull epochBalances directly from there instead of having to publish epochProcess (in lodestar-beacon-state-transition) to lodestar, the consequence of that is:

  • No need different types of EpochContext (StateTransitionEpochContext, LodestarEpochContext), only EpochContext
  • epochProcess stays internal to lodestar-beacon-state-transition and hence it's not a concern

we need to do this cleanup work before implementing CachedBeaconState

this reverts most of changes in #1702

@twoeths twoeths marked this pull request as draft January 15, 2021 15:19
@codeclimate
Copy link

codeclimate bot commented Jan 15, 2021 •
edited

Code Climate has analyzed commit f6aefc9 and detected 0 issues on this pull request.

View more on Code Climate.

@twoeths twoeths marked this pull request as ready for review January 18, 2021 09:33
dapplion
dapplion previously approved these changes Jan 19, 2021
View reviewed changes
@wemeetagain wemeetagain added this to the 0.15.0 milestone Jan 19, 2021
@wemeetagain wemeetagain merged commit c05429c into master Jan 25, 2021
@wemeetagain wemeetagain deleted the tuyen/one-epoch-context branch January 25, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@dapplion dapplion dapplion approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twoeths @wemeetagain @dapplion