ReqResp does not return null in any case #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reqResp request never return null. For protocols with multiple responses, return an array possibly empty. For single response protocols, return 1 response or throw an error. Current types added unnecessary complexity for an out-of-spec situation
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
github-actions
bot
added
the
scope-networking
|
Code Climate has analyzed commit 6be3fbf and detected 0 issues on this pull request. View more on Code Climate. |
wemeetagain
approved these changes
Feb 18, 2021
dapplion
commented
Feb 18, 2021
| return async (source) => { | ||
| if (isRequestSingleChunk(method)) { | ||
| for await (const response of source) { | ||
| return response as T; | ||
| } | ||
| return null; | ||
| throw new RequestInternalError({code: RequestErrorCode.EMPTY_RESPONSE}); |
There was a problem hiding this comment.
methods that isRequestSingleChunk must return exactly 1 response chunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqResp request never returns null. For protocols with multiple responses, returns an array possibly empty. For single response protocols, returns 1 response or throw an error. Current types added unnecessary complexity for an out-of-spec situation