Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getAttestationDeltas performance test #2064

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Feb 19, 2021

part of #2046

  • Fix and restructure the current performance tests
  • Add getAttestationDeltas.test.ts showing that it may finish in more than 1s as in the profiler:
# minTime (ms) maxTime (ms) average (ms)
1st 98 1375 130
2nd 97 699 131

@codeclimate
Copy link

codeclimate bot commented Feb 19, 2021

Code Climate has analyzed commit 5a24111 and detected 0 issues on this pull request.

View more on Code Climate.

@twoeths twoeths marked this pull request as ready for review February 19, 2021 08:01
@twoeths
Copy link
Contributor Author

twoeths commented Feb 19, 2021

I'm not familiar with assembly-script. Since getAttestationDeltas mainly doBigIntUintType({byteLength: 8}) operations, can we use u64 type of assembly-script and implement the function in wasm @ChainSafe/eth2-0 ? at least we want it to be predictable.

@mpetrunic
Copy link
Member

I'm not familiar with assembly-script. Since getAttestationDeltas mainly doBigIntUintType({byteLength: 8}) operations, can we use u64 type of assembly-script and implement the function in wasm @ChainSafe/eth2-0 ? at least we want it to be predictable.

We could but not sure if worth it since I think that method is removed in HF1 and replaced with https://github.com/ethereum/eth2.0-specs/blob/dev/specs/lightclient/beacon-chain.md#get_flag_deltas

It might be better to write new method in assemblyscript later on

@wemeetagain wemeetagain merged commit 31e72d0 into master Feb 19, 2021
@wemeetagain wemeetagain deleted the tuyen/getAttestationDeltas_performance_test branch February 19, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants