Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BeaconGossipHandler #2067

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Conversation

dapplion
Copy link
Contributor

  • Store forkDigest in an enum state variable
  • Subscribe to all core topics on start
  • Sync calls start() instead of handleSyncComplete(), it's the sync instance responsibility to know that gossip must start when completing sync not the other way around

@github-actions github-actions bot added the scope-networking All issues related to networking, gossip, and libp2p. label Feb 19, 2021
@codeclimate
Copy link

codeclimate bot commented Feb 19, 2021

Code Climate has analyzed commit 8ce933c and detected 0 issues on this pull request.

View more on Code Climate.

@dapplion dapplion force-pushed the dapplion/BeaconGossipHandler branch 2 times, most recently from a3d387c to 10f2593 Compare February 19, 2021 10:51
- Store forkDigest in an enum state variable
- Subscribe to all core topics on start
- Sync calls start() instead of handleSyncComplete(), it's the sync instance responsibility to know that gossip must start when completing sync not the other way around
@dapplion
Copy link
Contributor Author

The sim tests fail because some of the nodes don't reach justification. Some of them fall behind randomly and are unable to keep up.

Test run 1

[NODE 0]           info: Synced - finalized: 0 0x0000…0000 - head: 7 0x3aa0…008a - peers: 3
[NODE 2]           info: Syncing - 25 seconds left - 0.200 slots/s - finalized: 0 0x0000…0000 - head: 3 0x52fe…4d95 - currentSlot: 8 - peers: 3
[NODE 1]           info: Synced - finalized: 0 0x0000…0000 - head: 7 0x3aa0…008a - peers: 3
[NODE 3]           info: Synced - finalized: 0 0x0000…0000 - head: 1 0xe9d5…68be - peers: 3

Test run 2

[NODE 3]           info: Synced - finalized: 0 0x0000…0000 - head: 1 0xacbe…cf57 - peers: 3
[NODE 0]           info: Synced - finalized: 0 0x0000…0000 - head: 23 0xcd5c…faac - peers: 3
[NODE 1]           info: Synced - finalized: 0 0x0000…0000 - head: 23 0xcd5c…faac - peers: 3
[NODE 2]           info: Synced - finalized: 0 0x0000…0000 - head: 23 0xcd5c…faac - peers: 3

@wemeetagain wemeetagain merged commit e4d6b88 into master Feb 21, 2021
@wemeetagain wemeetagain deleted the dapplion/BeaconGossipHandler branch February 21, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants