Fix asssertPeerRelevance during pre-genesis #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
requested review from
dapplion,
mpetrunic and
twoeths
as code owners
github-actions
bot
added
the
scope-networking
|
Code Climate has analyzed commit 220e874 and detected 0 issues on this pull request. View more on Code Climate. |
mpetrunic
approved these changes
Feb 23, 2021
|
|
||
| it("Accept during pre-genesis clock", () => { | ||
| // clock slot pre-genesis (< 0) by a good margin | ||
| (chain as any).clock.currentSlot = -50; |
There was a problem hiding this comment.
Would be nicer to not cast as any (in case we rename or move clock we won't detect error here) but unlikely to happen so I guess it's fine
twoeths
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peers were not connecting before genesis (due to clock skew between headSlot=0 and currentSlot=-N)
Fixes issues seen in sim tests