Lightclient patch spec tests #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mpetrunic
commented
Mar 5, 2021
•
mpetrunic
commented
- missing ssz static tests - not sure how I'm suppose modify them to accomodate hf1
- removed process_final_updates fast spec tests - method was refactored in phase0 that we didn't reflect in our code
mpetrunic
requested review from
dapplion,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit 99a5ac0 and detected 15 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
wemeetagain
requested changes
Mar 6, 2021
packages/lodestar-beacon-state-transition/src/util/blockRoot.ts
Outdated
Show resolved
Hide resolved
packages/lodestar-beacon-state-transition/src/lightclient/naive/sync_committee.ts
Outdated
Show resolved
Hide resolved
wemeetagain
approved these changes
Mar 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.