-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gossip code #2132
Merged
Merged
Refactor gossip code #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
requested review from
dapplion,
mpetrunic and
twoeths
as code owners
March 6, 2021 00:08
github-actions
bot
added
Api
scope-networking
All issues related to networking, gossip, and libp2p.
labels
Mar 6, 2021
Code Climate has analyzed commit dcd7d4a and detected 11 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
dapplion
reviewed
Mar 6, 2021
dapplion
reviewed
Mar 6, 2021
dapplion
previously approved these changes
Mar 8, 2021
dapplion
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors gossip code and adds easier support for supporting future HFs
IForkInfo
interface,config.getForkInfoRecord()
, andcomputeForkNameFromForkDigest
Gossip
wrapper, all logic is onEth2Gossipsub
, a class that extendsGossipsub
.GossipTopic
that supports referencing a topic in a friendly wayForkDigest
event handlers can/should be replaced withIForkName
event handlers.genesisValidatorsRoot
is a constant, we can code in terms ofIForkName
and derive aForkDigest
if/when/where its neededFixes #2083