Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public modifier #2159

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Remove public modifier #2159

merged 2 commits into from
Mar 11, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Mar 10, 2021 •
edited

From #2070 poll to remove public modifiers. Fixes #2070

As future work it would be nice to add private and readonly where applicable to restrict as much as possible the scope of class properties

@github-actions github-actions bot added Api scope-networking All issues related to networking, gossip, and libp2p. labels Mar 10, 2021
@codeclimate
Copy link

codeclimate bot commented Mar 10, 2021 •
edited

Code Climate has analyzed commit e04e3c2 and detected 0 issues on this pull request.

View more on Code Climate.

mpetrunic
mpetrunic reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modify eslint to enforce those changes?

@dapplion
Copy link
Contributor Author

Can you modify eslint to enforce those changes?

I searched for it but could found a rule that enforces this. Please let me know if there's one!

@mpetrunic
Copy link
Member

Can you modify eslint to enforce those changes?

I searched for it but could found a rule that enforces this. Please let me know if there's one!

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/explicit-member-accessibility.md

'no-public'

@wemeetagain wemeetagain mentioned this pull request Mar 11, 2021
Closed
@wemeetagain wemeetagain merged commit 3f720ee into master Mar 11, 2021
@wemeetagain wemeetagain deleted the dapplion/no-public-modifier branch March 11, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic mpetrunic approved these changes

@twoeths twoeths Awaiting requested review from twoeths

Assignees
No one assigned
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code style: Omit public modifier
3 participants
@dapplion @mpetrunic @wemeetagain