Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abortable source wrapper from response source #2163

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

wemeetagain
Copy link
Member

There was a memory leak stemming from using abortable-iterator and neither fully draining the iterator nor aborting it.
abortable-iterator attaches an abort signal listener and only removes the listener after:

  • the iterator is {done: true} OR
  • the iterator is aborted

In our case, collectResponses breaks out of the iterator after maxResponses # of iterations.
So every request was leaking a listener.

For now, remove the abortable source wrapper until we can figure out a better solution.

@github-actions github-actions bot added the scope-networking All issues related to networking, gossip, and libp2p. label Mar 11, 2021
@codeclimate
Copy link

codeclimate bot commented Mar 11, 2021

Code Climate has analyzed commit f3f0599 and detected 0 issues on this pull request.

View more on Code Climate.

@wemeetagain wemeetagain merged commit 820a0a2 into master Mar 11, 2021
@wemeetagain wemeetagain deleted the wemeetagain-patch-2 branch March 11, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants