Refactor path handling in CLI #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit 728ddbf and detected 0 issues on this pull request. View more on Code Climate. |
dapplion
force-pushed
the
dapplion/cli-same-dir-paths
branch
from
811ecad
to
9e32d78
Compare
dapplion
force-pushed
the
dapplion/cli-same-dir-paths
branch
from
9e32d78
to
728ddbf
Compare
wemeetagain
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current version, if you run the CLI with
the logs will not be at
./logs.txtbut in/home/lion/.local/share/lodestar/mainnet/logs.txt. This is very un-intuitive.This PR changes the processing of paths so that if a path is defined it will be used as is. If it's not defined it will be computed with parent paths that may change.