Gossip validation - log error metadata instead on logContext #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
github-actions
bot
added
the
scope-networking
|
Code Climate has analyzed commit 3223411 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
wemeetagain
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2199
Logging so much data about the incoming attestations and aggregates is not actionable. As a consumer of logs the most useful information is the error itself, with its attached metadata. For example for
FUTURE_SLOTyou'll getwhich is more actionable that the hashTreeRoot of the aggregate. Also, computing the hashTreeRoot of attestations and aggregates is a non-trivial task that currently is done always, even when running in "production" mode, with logLevel >= info.
This PR changes from logging the entire error to only the
typemetadata, ommitting the unnecessary stack trace