Add BeaconCommitteeSubscription ssz type #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 84760d9 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
twoeths
requested review from
dapplion,
mpetrunic and
wemeetagain
as code owners
dapplion
reviewed
Mar 25, 2021
dapplion
approved these changes
Mar 25, 2021
mpetrunic
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2145
Motivation
There is no ssz type for BeaconCommitteeSubscription so validator does not use snack case to conform to the standard api
Description
Add ssz type for it and validator should use `toJson({case: "snake"}) to communicate with node.
Steps to test or reproduce
Run lodestar e2e test.