Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix events api url in validator #2273

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Fix events api url in validator #2273

merged 2 commits into from
Mar 26, 2021

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Mar 26, 2021

Motivation

  • Fix event api url
  • Fix e2e tests (some failed in master but we just ignored the error)

Description

Closes #2020

Steps to test or reproduce

  • cd packages/lodestar
  • yarn test:sim:singleThread
  • More blocks are proposed there, this made the test run faster

@codeclimate
Copy link

codeclimate bot commented Mar 26, 2021

Code Climate has analyzed commit 33b7f75 and detected 0 issues on this pull request.

View more on Code Climate.

@twoeths twoeths marked this pull request as ready for review March 26, 2021 05:49
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wemeetagain wemeetagain merged commit dc83dce into master Mar 26, 2021
@wemeetagain wemeetagain deleted the tuyen/fix-events-api branch March 26, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator client has wrong events api url
4 participants