Add JobQueue for each gossip topic #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
github-actions
bot
added
the
scope-networking
|
Code Climate has analyzed commit 150582d and detected 0 issues on this pull request. View more on Code Climate. |
wemeetagain
approved these changes
Mar 29, 2021
| | ((voluntaryExit: phase0.SignedVoluntaryExit) => Promise<void> | void) | ||
| | ((proposerSlashing: phase0.ProposerSlashing) => Promise<void> | void) | ||
| | ((attesterSlashing: phase0.AttesterSlashing) => Promise<void> | void); | ||
| export type GossipTopic = GossipTopicMap[keyof GossipTopicMap]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #2265
Description
Add a single queue for each gossip topic. Numbers are copied from here to start
https://github.com/sigp/lighthouse/blob/b34a79dc0b02e04441ba01fd0f304d1e203d877d/beacon_node/network/src/beacon_processor/mod.rs#L772-L825
but should be adjusted after experimentation in production settings
Closes #2265 closes #2241
Steps to test or reproduce