Use BLS batch verify in AggregateAndProof #2284

dapplion · 2021-03-28T17:57:20Z

Motivation

See #2225

Description

Moves the BLS signature sets types to the utils folder since it is not tied to phase0 or fast.
Gets 3 signature sets from AggregateAndProof, and verifies them in batch

I have not confirmed the performance improvement in production

Closes #2225

codeclimate · 2021-03-28T17:58:07Z

Code Climate has analyzed commit 9166d22 and detected 0 issues on this pull request.

View more on Code Climate.

wemeetagain

👍 We really don't need to know which signature is incorrect/why the aggAndProof is invalid. Will be interesting to see the improvement.

dapplion · 2021-03-29T06:15:45Z

packages/beacon-state-transition/src/util/index.ts

-export * from "./shuffle";
-export * from "./genesis";
+export * from "./validator";
+export * from "./validatorStatus";


Sorted alphabetically to be able to track what we are exporting

dapplion added 3 commits March 28, 2021 19:46

Move signature sets types to utils

84a655b

Batch BLS verify aggregates

5c1ddf7

Update tests

9166d22

dapplion requested review from mpetrunic, twoeths and wemeetagain as code owners March 28, 2021 17:57

github-actions bot added scope-networking All issues related to networking, gossip, and libp2p. StateTransition labels Mar 28, 2021

wemeetagain approved these changes Mar 29, 2021

View reviewed changes

dapplion commented Mar 29, 2021

View reviewed changes

mpetrunic approved these changes Mar 29, 2021

View reviewed changes

3xtr4t3rr3str14l approved these changes Mar 29, 2021

View reviewed changes

wemeetagain merged commit ea43a75 into master Mar 29, 2021

wemeetagain deleted the dapplion/aggregate-batch-verify branch March 29, 2021 20:12

Provide feedback