Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validator functions for attestation topics #2299

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Mar 30, 2021

Motivation

#2296 is not the root cause to resolve #2283

Description

We use the wrong validation function mapping between Attesttation vs AggregateAndProof

revert #2296
close #2283

@github-actions github-actions bot added the scope-networking All issues related to networking, gossip, and libp2p. label Mar 30, 2021
@codeclimate
Copy link

codeclimate bot commented Mar 30, 2021

Code Climate has analyzed commit 7ec43d3 and detected 0 issues on this pull request.

View more on Code Climate.

@twoeths twoeths marked this pull request as ready for review March 30, 2021 13:46
@wemeetagain wemeetagain merged commit 43b876d into master Mar 30, 2021
@wemeetagain wemeetagain deleted the tuyen/fix-gossip-validator-fn branch March 30, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in getAttestationAttesterCount() attestation.aggregationBits = null
2 participants