Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
prom-client
native classes do not have sufficient features to allow the gossip validation queue metrics to be separated by labels instead of different metric names. Having a singlegossip_validation_queue
and then each topic use a different label simplifies a lot the charts in Grafana.Description
GaugeExtra
andHistogramExtra
which allow to:collect()
functions after instantiation.IBeaconMetrics
toIMetrics