Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we run into an annoying type situation when trying to perform ssz operations on types from a fork known only at runtime.
eg:
getTypes
returnsIPhase0SSZTypes | IAltairSSZTypes ...
.This means
getTypes().BeaconBlock
resolves toContainerType<phase0.BeaconBlock> | ContainerType<altair.BeaconBlock> ...
,which can be further resolved to
ContainerType<phase0.BeaconBlock & altair.BeaconBlock ...>
.This intersection type is not what we want, and the way to resolve the issue is with an additional typecast.
Description
The
IPhase0SSZTypes | IAltairSSZTypes ...
return type has been replaced withIAllForksSSZTypes
, which has relevant types replaced with theirallForks
variant.This allows for code like the example above to work without additional casting.