Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix winston logger and tests #2314

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Fix winston logger and tests #2314

merged 4 commits into from
Mar 31, 2021

Conversation

dapplion
Copy link
Contributor

Motivation

  • Log to file in tests is not as stable as logging to stream. Tests may randomly fail. Now they should never fail
  • Child logger option parsing did not override the transport default, ignoring the logger.yyy.level debug cli options

Description

Closes #2305
Closes #2310

@codeclimate
Copy link

codeclimate bot commented Mar 31, 2021 •
edited

Code Climate has analyzed commit a3ed067 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions github-actions bot added the CLI label Mar 31, 2021
@wemeetagain wemeetagain merged commit 00988a9 into master Mar 31, 2021
@wemeetagain wemeetagain deleted the dapplion/winston-tests branch March 31, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

@twoeths twoeths Awaiting requested review from twoeths

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate why logger option does not work Winston unit test failed in CI
2 participants
@dapplion @wemeetagain