Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queue charts to dashboard #2332

Merged
merged 4 commits into from
Apr 6, 2021
Merged

Add queue charts to dashboard #2332

merged 4 commits into from
Apr 6, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Apr 6, 2021 •
edited

Motivation

Add more charts with new queue metrics

Description

Also:

  • Left-pad subnet label. Correctly sort them, otherwise Grafana does: [1,10,11,12]
  • Improve local version info fetching to show in the Grafana dashboard on Dockerized and non-Dockerized setups
  • Move local version info fetching logic to the CLI
  • Print to console the local version info

Screenshot from 2021-04-06 10-16-22

Screenshot from 2021-04-06 10-16-11

Screenshot from 2021-04-06 10-16-42

@codeclimate
Copy link

codeclimate bot commented Apr 6, 2021 •
edited

Code Climate has analyzed commit 16f3d6b and detected 0 issues on this pull request.

View more on Code Climate.

twoeths
twoeths previously approved these changes Apr 6, 2021
View reviewed changes
@github-actions github-actions bot added the scope-networking All issues related to networking, gossip, and libp2p. label Apr 6, 2021
@github-actions github-actions bot added the CLI label Apr 6, 2021
@dapplion
Copy link
Contributor Author

dapplion commented Apr 6, 2021

Also:

  • Left-pad subnet label. Correctly sort them, otherwise Grafana does: [1,10,11,12]
  • Improve local version info fetching to show in the Grafana dashboard on Dockerized and non-Dockerized setups
  • Move local version info fetching logic to the CLI
  • Print to console the local version info

wemeetagain
wemeetagain approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@wemeetagain wemeetagain merged commit e846581 into master Apr 6, 2021
@wemeetagain wemeetagain deleted the dapplion/add-queue-charts branch April 6, 2021 12:41
@twoeths twoeths mentioned this pull request Jul 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@twoeths twoeths twoeths left review comments

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

Assignees
No one assigned
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dapplion @wemeetagain @twoeths