Reduce perf test start-up time #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit b66937a and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
dapplion
force-pushed
the
dapplion/perf-test-review
branch
from
7835ebe
to
67ad0a4
Compare
wemeetagain
previously approved these changes
Apr 8, 2021
dapplion
force-pushed
the
dapplion/perf-test-review
branch
from
67ad0a4
to
b66937a
Compare
twoeths
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Running any performance test requires 1m 36s just to prepare the state and its context
Description
This PR reduces the number of BLS opts required to do that, now taking 12s to prepare the state + context. It allows much faster code iteration and experimentation, at the cost of and opts argument not used in production.