Precompute OR flags #2341
Merged
Precompute OR flags #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit d94c525 and detected 0 issues on this pull request. View more on Code Climate. |
|
|
twoeths
previously approved these changes
Apr 9, 2021
|
Can we hold off on this and #2348 until after we add the participation cache? |
wemeetagain
approved these changes
Apr 9, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reduce unnecessary opts in hot paths
Description
Pre-computes the OR of flags to not do that on every loop of getAttestationDeltas().
getAttestationDeltas()by 16%