Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum for ForkName #2428

Merged
merged 3 commits into from Apr 26, 2021
Merged

Use enum for ForkName #2428

merged 3 commits into from Apr 26, 2021

Conversation

dapplion
Copy link
Contributor

Motivation

Typing the same string is not as clean as an enum. Switched to enum for consistency with the rest of the codebase.

Description

  • Use enum for ForkName
  • Use Map s in the abstract db repos to prevent casting to ForkName

@github-actions github-actions bot added Config scope-networking All issues related to networking, gossip, and libp2p. labels Apr 26, 2021
@codeclimate
Copy link

codeclimate bot commented Apr 26, 2021 •
edited

Code Climate has analyzed commit 82d87f2 and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 8

View more on Code Climate.

@wemeetagain wemeetagain merged commit 8e1f5b0 into master Apr 26, 2021
@wemeetagain wemeetagain deleted the dapplion/forkname-enum branch April 26, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

@twoeths twoeths Awaiting requested review from twoeths

Assignees
No one assigned
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dapplion @wemeetagain