Use block state slot to get fork type #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
github-actions
bot
added
Api
scope-networking
dapplion
changed the title
dapplion
force-pushed
the
dapplion/slot-fork-key
branch
from
8e6f4d5
to
0fc41f9
Compare
|
Code Climate has analyzed commit 0fc41f9 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
wemeetagain
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A simpler strategy to handling multi-fork types is to deserialize the slot of the type first. This approach allows to store everything in the same bucket and allows and has almost no complexity cost.
It makes sense conceptually, you want to encode the type of the blob in the value not the key. The key should be the indexer (slot, root) which is independent of the type. A valid approach would be to encode the type as
insteadin this approach we do
This way we are backwards compatible and have to store no extra data.
Description
Reverts #2320 and adds some methods to get the slot from a block or state blob.