Add state transition function metrics #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit 5698fae and detected 0 issues on this pull request. View more on Code Climate. |
dapplion
force-pushed
the
dapplion/bstfn-metrics
branch
from
271df2b
to
c9e6f3b
Compare
Update test types Update test types
dapplion
force-pushed
the
dapplion/bstfn-metrics
branch
from
76f828c
to
5698fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to know how long a epoch transition and block processing takes. This is arguably one of the most important metrics for us that we are currently trying to minimize, so we need to measure it.
Description
Closes #2426
The consumer code of the beacon state transition function is a bit messy so I've re-arranged it a bit so it's clearer what functions are local and which are exported